Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new pipeline task to publish .pdb symbol files as build artifacts under the name mssql-python-symbols.
- Introduces a
PublishBuildArtifacts@1step conditioned on success or failure - Points
PathtoPublishat$(Build.ArtifactStagingDirectory)\all-pdbs - Uses
mssql-python-symbolsas the artifact name
Comments suppressed due to low confidence (2)
eng/pipelines/build-whl-pipeline.yml:165
- Use forward slashes for
PathtoPublishto ensure cross-platform compatibility (e.g.,$(Build.ArtifactStagingDirectory)/all-pdbs).
PathtoPublish: '$(Build.ArtifactStagingDirectory)\all-pdbs'
eng/pipelines/build-whl-pipeline.yml:161
- [nitpick] Consider adding a preceding step to create or clean the
all-pdbsdirectory so that you don’t publish stale or missing artifacts.
# Publish the collected .pdb file(s) as build artifacts
bewithgaurav
commented
Jun 25, 2025
| SymbolsProduct: mssql-python | ||
| # Have kept the default version as the build ID, which is unique for each build | ||
| # This will be used to identify the symbols in the symbol server | ||
| SymbolsVersion: $(Build.BuildId) |
Collaborator
Author
There was a problem hiding this comment.
Need to change ID for SymbolsVersion - perhaps the driver release version?
| env: | ||
| SymbolServer: '$(SymbolServer)' | ||
| SymbolTokenUri: '$(SymbolTokenUri)' | ||
| requestName: '$(Build.DefinitionName)-$(Build.BuildId)' |
Collaborator
Author
There was a problem hiding this comment.
kept this since requestName needs to be unique for each API call. Might need to change this?
David-Engel
reviewed
Jun 30, 2025
Co-authored-by: David Engel <[email protected]>
github-actions
bot
added
pr-size: medium
github-actions
bot
added
pr-size: medium
github-actions
bot
added
pr-size: medium
github-actions
bot
added
pr-size: medium
github-actions
bot
added
pr-size: medium
github-actions
bot
added
pr-size: medium
github-actions
bot
added
pr-size: medium
github-actions
bot
added
pr-size: medium
github-actions
bot
added
pr-size: medium
Collaborator
Author
|
this PR is now outdated as we've migrated to 1ES, closing this now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADO Work Item Reference
Summary
This pull request includes a small addition to the build pipeline configuration in
eng/pipelines/build-whl-pipeline.yml. The change adds a new task to publish.pdbfiles as build artifacts under the namemssql-python-symbols.